Filter from original rows, not current #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Added option to filter from the original list of rows rather than what is currently being displayed
My reasoning
Just plugging this library into my app, I noticed the filter would only filter the rows that were displayed on screen, not the original set of rows loaded. I needed the ability to use backspace to start the filter over instead of hitting a reset button. If what I described is how this library actually works, then I may have been running into a bug and you can just close this PR.
Example
With this list:
Filtering to
Jo
would only showJohn
andJohnny
, but backspacing to justJ
wouldn't bringJim
back to the list.