Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter from original rows, not current #15

Merged
merged 1 commit into from Dec 23, 2014

Conversation

lukebooth
Copy link
Contributor

What this does

Added option to filter from the original list of rows rather than what is currently being displayed

My reasoning

Just plugging this library into my app, I noticed the filter would only filter the rows that were displayed on screen, not the original set of rows loaded. I needed the ability to use backspace to start the filter over instead of hitting a reset button. If what I described is how this library actually works, then I may have been running into a bug and you can just close this PR.

Example

With this list:

-- Luke
-- Jim
-- John
-- Johnny

Filtering to Jo would only show John and Johnny, but backspacing to just J wouldn't bring Jim back to the list.

…er than what is currently being displayed (5m)
jbritten added a commit that referenced this pull request Dec 23, 2014
Filter from original rows, not current
@jbritten jbritten merged commit 8cba0bb into jbritten:master Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants