Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Navigation Not Working with IE9 #88

Closed
mbcollins opened this issue Apr 16, 2012 · 9 comments
Closed

Page Navigation Not Working with IE9 #88

mbcollins opened this issue Apr 16, 2012 · 9 comments
Labels

Comments

@mbcollins
Copy link

I'm on Windows 7 Ultimate. IE 9.0.8112.16421
Just completed a fresh install of ElefantCMS on Linux Ubuntu

Steps to replicate:

  1. logged in as admin
  2. Went to Pages.
  3. Created New Page with id of 'test-page' and Title of 'Test Page'
  4. Placed one sentence in the body.
  5. Set the page layout to 'default'
  6. Set the access to 'public'
  7. Saved Page
  8. Went to Tools -> Navigation. Here I can see the Test Page (test-page) in Other Pages.
  9. I can drag the test-page over to the left side.
  10. As I drag-mouse-over the test-page to the "Home" page on the right. The test page icon changes from a red X to a green checkmark.

The test page remains under the Home page, as expected, for as long as I remain on this page. However, if I leave this page and then come back, the test-page is no longer under this page. It is back on the right hand side, as if I hadn't done anything.

When I follow the same steps using FireFox 11, I find the test-page remains under the home page, even if I leave the Tools -> Navigation page and come back. However, when I leave the test-page under the 'home' page on the right and then log out and login again with IE9, the test-page is not visible under the "home" page, nor is it visible under other pages. If I log out again and view Tools -> Navigation with FireFox 11, the test-page is under the 'home' page on the left as expected.

@jbroadway
Copy link
Owner

Wanted to say I should have time to investigate this one tomorrow.

@jbroadway
Copy link
Owner

Can you try an edit out for me: Open the file apps/navigation/handlers/admin.php and change this:

$page->title = i18n_get ('Navigation');
$page->layout = 'admin';
$page->add_script ('<script src="/apps/navigation/js/jquery.jstree.js"></script>');

to this:

$page->title = i18n_get ('Navigation');
$page->layout = 'admin';
$page->add_script ('<script src="/apps/navigation/js/jquery.jstree.js"></script>');
$page->add_script ('<meta http-equiv="X-UA-Compatible" content="IE=edge" />');

Let me know if that gets it working for you.

@shortjared
Copy link
Contributor

I had this same issue. Make sure that your root/conf file is editable. (0755 or 0777)

You can check the calls (to navigation/api) and see if you get a json object returned with failed status, most likely it is due to a non-writable root/conf directory. The navigation.json file was causing issues for me.

@jbroadway
Copy link
Owner

I'm wondering if a rewrite of the drag & drop functionality with something like this would be better. This still seems wonky in IE and Opera to me.

@shortjared
Copy link
Contributor

What if we kill the drag and drop concept? It is incredibly buggy, even on chrome (Ubuntu 12.04) it still misbehaves.

I like how intuitive the concept is, but the support just isn't there.

@jbroadway
Copy link
Owner

What would be the alternative? I'm totally open to suggestions, but we definitely need something for it.

I've been thinking it might take writing the tree logic on top of the basic jQuery draggable/droppable plugins, or maybe we can find a non-jQuery tree library with drag & drop and better browser support...

@shortjared
Copy link
Contributor

On 07/25/2012 12:33 PM, Johnny Broadway wrote:

What would be the alternative? I'm totally open to suggestions, but we definitely need something for it.

I've been thinking it might take writing the tree logic on top of the basic jQuery draggable/droppable plugins, or maybe we can find a non-jQuery tree library with drag & drop and better browser support...


Reply to this email directly or view it on GitHub:
#88 (comment)
I will look into it more. The way I used to do it when I wrote my own
framework was more archaic with navigation being selected on a par page
basis when editing that particular page. Which is incredibly slow and
unintuitive.

I like the drag and drop, so maybe it's just finding the right library
to do it with.

@wokkie
Copy link

wokkie commented Aug 3, 2012

Silverstripe 3 uses this same methodology and libraries it seems. It works quite well (in the latest release) but has faced similar issues in the previous one, though there was a case of the emperor's new clothes with the development team. It seems solid enough now though. Maybe worth a look at what they did with the latest update?

@jbroadway
Copy link
Owner

Just found this library that seems to do the same thing as well:

https://github.com/mjsarfatti/nestedSortable

Seems to have good browser support, but lacking info on adding/removing nodes. Although, it is built on jQuery UI's Sortable, I imagine the events for that would be the same.

jbroadway added a commit that referenced this issue Sep 15, 2012
Updating to the latest code from Github fixed IE not reading the
tree hierarchy correctly. Still buggy in IE but this helps, and
jstree 1.0 is close too, so upgrading is likely the best path
forward once that's out. None of the other libraries handle
trees, so replacement with another library would be much more
difficult.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants