Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multibalance.plot issues #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ppanko
Copy link

@ppanko ppanko commented Jun 25, 2020

Hello!

I've had some problems with multibalance.plot recently and I would like to propose the following changes:

  • When suppling tmatch as the only argument, the function breaks because it's looking for results which does not exist in the scope. I've changed this reference to tmatch, which seems to work.
  • Certain instances of matrix subsetting (e.g., covs[,cols]) break if there is only one variable supplied by cols because the object reduces to a vector whereas it is usually expected to be a data.frame. I've changed these to use list subsetting such that the object will always be a data.frame regardless of the number of variables in cols.
  • Class checks of the type object == "class" break if the object has multiple class attributes, so I changed them to be more robust (e.g., is.logical/is.factor).

Thanks in advance for your attention!

Pavel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant