-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with debug asserts #27
Comments
What version (or commit) of cavalier contours are you using? I was unable to trigger a debug assert from those inputs using the latest on master (commit: 08200b5). |
Hello! Thats interesting, i've checked asserts after using this scripts:
and And expected that latest master will be used (checked manually, yes, i use latest) Anyway, i took input data from my logs as intermediate result, i will check data separately, also i will check directories and dataflow more carefully tomorrow, thank you! |
Here is how I tested inputs: Then I use "COPY TEST CODE" button and run test under debug build in Rust. |
Hello! |
Hello again!
Looks like i gave you wrong vector. sorry( Best regards, |
And another assert with this dataset:
Assert:
|
I am able to reproduce both those cases, I looked into them briefly, they both just affect accuracy at the epsilon thresholds. The first one (assert in pline_boolean) I think indicates the code can be changed to improve accuracy in certain cases, and the other one (assert in point_from_parametric) I think is just too strict a debug assert but I need to dig into it further. I'll work on these more and fix them when I find some time in next few days. |
For case number 2 I've tracked the issue down to For case number 1 I'm realizing the The slice end points that are joined together are always at intersect points and therefore I think should be within the What's happening in case 1 is there is more than 1 candidate slice to join to when using |
OK I removed the Both cases you reported should be fixed and I added them as test cases. Thanks for the bug report. Closing this issue, please make a new issue if you find more problem cases. |
Hello I still have a problem when running my code in debug mode.
Calling
|
@zdila Can you make a new issue and also try using the latest on master branch? |
@jbuckmccready I apologize, with |
@zdila I made a new release, |
Hello!
I've continued investigations from topic #23
Got several new results.
Input vectors:
In debug mode i see assert failure:
C Code:
Assert fails in debug mode only.
Could you please check it.
There are several additional similar troubles. Could you please clarify, do you need input vectors data for this type of issues?
Im asking because i can copy-paste Rust backtrace in one minute, but grabbing faulty vectors takes time.
For example:
Best regards,
Andrei Rodionov
The text was updated successfully, but these errors were encountered: