New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed epsilon comparison in line_circle_intr for better accuracy #30

Merged

jbuckmccready merged 2 commits into master from fix_line_circle_intr_accuracy

Mar 23, 2023

Owner

jbuckmccready commented Mar 23, 2023 •

edited

Test case added which triggers debug assert that found the problem. This fixes one of the cases (case 2) reported in #27.

This applies to case where line is nearly vertical (p0.x - p1.x very close to 0).

jbuckmccready added 2 commits

March 23, 2023 02:29


          Fixed epsilon comparison in line_circle_intr for better accuracy

c84c37d

Test case added which triggers debug assert that found the problem.


          Update CHANGELOG.md

b6114bf

jbuckmccready merged commit aca60c6 into master

jbuckmccready deleted the fix_line_circle_intr_accuracy branch

March 23, 2023 09:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment