Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Scrollable menu elements are being rendered outside of scrolling bounds #50

Closed
2 tasks done
jbunke opened this issue Apr 5, 2024 · 1 comment
Closed
2 tasks done
Assignees
Milestone

Comments

@jbunke
Copy link
Owner

jbunke commented Apr 5, 2024

Bug in action

Bug description

Instances of ScrollableMenuElement are being rendered when they have been displaced outside of the bounds of the ScrollingMenuElement that contains them. This bug was observed in a devbuild for v0.3.0 and I could not replicate it in 0.2.0.1.

Expected behaviour

Do not render (or process) child ScrollableMenuElement instances when they have been displaced outside of the bounds of their container.

Tasks

  • Investigate ScrollingMenuElement and its parent class MenuElementContainer
  • Investigate ScrollableMenuElement
@jbunke jbunke added the bug label Apr 5, 2024
@jbunke jbunke added this to the v0.3.0 milestone Apr 5, 2024
@jbunke jbunke self-assigned this Apr 5, 2024
@jbunke
Copy link
Owner Author

jbunke commented Apr 5, 2024

Ended up being an issue in MenuBuilder in Delta Time. Non-trivial inheritors of MenuElementContainer were being flattened in the MenuBuilder.add() function.

@jbunke jbunke closed this as completed Apr 5, 2024
@jbunke jbunke added the layout label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant