Fix for CI - Keep using older natural_earth version for testing #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natural Earth recently released a new version that changed some of the marine regions (e.g. #208), leading to incompatibility issues. Here I am using some new regionmask features to make sure that the older version is used for testing. This is an attempt to quickly fix the CI (which has failed for the last few weeks), but I am wondering if it would be worth in the long run, to upgrade to the latest NE version. Related question: @mathause, is there a way to identify the NE version from a regions object? Something similar to this: ```python basins = regionmask.defined_regions.natural_earth_v4_1_0.ocean_basins_50 assert basins.version == 'something' ``` ? That way I could check that in my module and give a more useful errormessage TODO: - [ ] Mention this in the docs.
jbusecke
changed the title
jbusecke
added a commit
that referenced
this pull request
Mar 16, 2022
Additionally to the problem with regionmask (which I started working on in #212), there seems to be an issue with a test asserting that a UserWarning is raised. I believe the issue here is that suddenly more than one warning is raised and my old implementation did only check the first warning. I have now changed this to a list comparison.
* Attempt to fix test checking for user warning Additionally to the problem with regionmask (which I started working on in #212), there seems to be an issue with a test asserting that a UserWarning is raised. I believe the issue here is that suddenly more than one warning is raised and my old implementation did only check the first warning. I have now changed this to a list comparison. * Update test_drift_removal.py * [skip-ci]
|
Ill merge this and add an issue to remind me to add this to the docs |
No unfortunately not - I didn't think of this but it's a good suggestion. |
|
That would be amazing to have. Happy to help with implementation if that is useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Natural Earth recently released a new version that changed some of the marine regions (e.g. #208), leading to incompatibility issues.
Here I am using some new regionmask features to make sure that the older version is used for testing.
This is an attempt to quickly fix the CI (which has failed for the last few weeks), but I am wondering if it would be worth in the long run, to upgrade to the latest NE version.
Related question: @mathause, is there a way to identify the NE version from a regions object?
Something similar to this:
?
That way I could check that in my module and give a more useful error message
TODO: