Improve __init__
#58
Merged
Improve __init__
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah nice catch. Thanks @zmoon. I would like to default to |
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 78.70% 78.70%
=======================================
Files 3 3
Lines 324 324
Branches 58 58
=======================================
Hits 255 255
Misses 46 46
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
zmoon
commented
Jun 24, 2021
| from ._version import __version__ | ||
|
|
||
| except ModuleNotFoundError: | ||
| __version__ == "unknown" |
There was a problem hiding this comment.
@jbusecke this should have been normal =, my bad
Merged
|
Got it. Ill fix that really quick. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had done
python -m pydoc xmovieand saw that the version there didn't match what it should be and the top level names weren't listed. Fixed by importing__version__and adding__all__.