Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #66

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Fix CI #66

merged 2 commits into from
Dec 7, 2021

Conversation

zmoon
Copy link
Contributor

@zmoon zmoon commented Oct 27, 2021

Fix the CI workflow so that it can pass.

Current error message, causing failure even though the main job passes, e.g. here:

Error when evaluating 'runs-on' for job 'core-deps-dev'. .github/workflows/ci.yaml (Line: 62, Col: 14): Unexpected value ''

Changes:

  • Give runs-on a value in job core-deps-dev

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #66 (9f84966) into master (c4b1223) will increase coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   78.70%   79.62%   +0.92%     
==========================================
  Files           3        3              
  Lines         324      324              
  Branches       59       59              
==========================================
+ Hits          255      258       +3     
+ Misses         46       43       -3     
  Partials       23       23              
Flag Coverage Δ
unittests 79.32% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xmovie/core.py 87.04% <0.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b1223...9f84966. Read the comment docs.

@jbusecke
Copy link
Owner

jbusecke commented Dec 7, 2021

Thanks so much for catching this @zmoon. And again, apologies for the long response time here.

@jbusecke jbusecke merged commit 4cad7b3 into jbusecke:master Dec 7, 2021
@zmoon zmoon deleted the fix-ci branch December 7, 2021 23:20
@zmoon
Copy link
Contributor Author

zmoon commented Dec 7, 2021

No problem @jbusecke !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants