Get environment from RACK_ENV if exists by default #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,9 +7,14 @@ | |||
| module Guard | |||
| class Puma < Guard | |||
| attr_reader :options, :runner | |||
|
|
|||
| def self.default_env | |||
| ENV['RACK_ENV'] || 'development' | |||
There was a problem hiding this comment.
I'm not a fan of the || pattern. Mind switching to Hash#fetch instead? Otherwise, looks good.
|
And in general, I'm curious how you use this in production? |
…ng initial ENV var value
|
My apologies - we actually don't. There was a bug in production that I was assuming was caused by this, but it wasn't. Thanks! |
|
Build is failing because |
jc00ke
added a commit
that referenced
this pull request
Nov 11, 2014
Get environment from RACK_ENV if exists by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it may be a good idea to get the environment from RACK_ENV by default.
We use this in production and recently traced a bug back to the environment not being set in Guard::Puma, so I figured others might have made the same mistake.