Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Java 7 #37

Closed
mkordas opened this issue Feb 9, 2016 · 7 comments
Closed

Update to Java 7 #37

mkordas opened this issue Feb 9, 2016 · 7 comments
Assignees
Labels

Comments

@mkordas
Copy link

mkordas commented Feb 9, 2016

Currently Travis build does not work for Java 6 on Travis (log from master branch), as Qulice requires at least Java 7:

Caused by: java.lang.UnsupportedClassVersionError: com/puppycrawl/tools/checkstyle/api/CheckstyleException : Unsupported major.minor version 51.0
    at java.lang.ClassLoader.defineClass1(Native Method)
    at java.lang.ClassLoader.defineClass(ClassLoader.java:643)
    at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
    at java.net.URLClassLoader.defineClass(URLClassLoader.java:277)
    at java.net.URLClassLoader.access$000(URLClassLoader.java:73)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:212)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(URLClassLoader.java:205)
    at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf(ClassRealm.java:401)
    at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42)
    at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
    at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:254)
    at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
    at com.qulice.maven.DefaultValidatorsProvider.external(DefaultValidatorsProvider.java:66)
    at com.qulice.maven.CheckMojo.run(CheckMojo.java:82)
    at com.qulice.maven.CheckMojo.doExecute(CheckMojo.java:59)
    at com.qulice.maven.AbstractQuliceMojo.execute(AbstractQuliceMojo.java:175)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
    ... 20 more

Let's update project to Java 7 and remove failing Travis build.

Moreover, let's do typical Java 6 - > Java 7 migration steps: use diamond operator, try-with-resources, etc.

@dmarkov
Copy link

dmarkov commented Feb 12, 2016

@yegor256 dispatch this issue please, see par.21

@yegor256 yegor256 added the bug label Feb 12, 2016
@dmarkov
Copy link

dmarkov commented Feb 16, 2016

@mkordas thanks for the ticket, your account was topped for 15 mins, payment 56c32b5753fc494c8a0002c4

@dmarkov
Copy link

dmarkov commented Mar 22, 2016

@nesterov-n can you please help? Keep in mind this. If you have any technical questions, don't hesitate to ask right here

Budget here is 30 mins (keep this principle in mind)

@nesterov-n
Copy link
Contributor

@dmarkov See my PR #38

@dmarkov
Copy link

dmarkov commented Mar 23, 2016

@dmarkov See my PR #38

@nesterov-n thank you

@nesterov-n
Copy link
Contributor

@mkordas I believe that all is done here. Can you close issue?

@mkordas mkordas closed this as completed Mar 29, 2016
@dmarkov
Copy link

dmarkov commented Mar 30, 2016

@nesterov-n Many thanks! 30 mins were added to your account in Transaction ID AP-7HR88999GH051831E (task took 167 hours and 31 mins); +30 added to your rating, current score is: -28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants