Skip to content

Commit

Permalink
LPS-98334 Remove redundant ESLint extensions
Browse files Browse the repository at this point in the history
As described here:

liferay/eslint-config-liferay#53

I realized that we don't need to include "liferay/portal" explicitly
because it already has effect everywhere, automatically, thanks to
liferay-npm-scripts.

I'll make the next version of liferay-npm-scripts detect and report this
kind of redundancy to stop these sneaking in again.
  • Loading branch information
wincent authored and CsabaTurcsan committed Oct 19, 2019
1 parent 2950ea4 commit 9e31303
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
*/

module.exports = {
extends: ['liferay/portal', 'liferay/react']
extends: ['liferay/react']
};
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
*/

module.exports = {
extends: ['liferay/portal', 'liferay/react'],
extends: ['liferay/react'],
globals: {
mount: true,
shallow: true
Expand Down

0 comments on commit 9e31303

Please sign in to comment.