Python pass #120
Open
Python pass #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarreira
commented
Mar 8, 2019
|
|
||
| if num_lambdas == None: | ||
| if num_lambdas == None: # not clear when this can happen. It seems to me self.get_num_lambdas() never returns None |
There was a problem hiding this comment.
@yangryan0 Can you please check this?
There was a problem hiding this comment.
self.get_num_lambdas returns none when there is no response from the parameter server or the connection times out.
|
|
||
| # it doesn't make sense to have this code here | ||
| # why are we launching lambdas in a get_update_per_seconds() method? | ||
| # isn't that what the wait_then_maintain_workers code does? |
There was a problem hiding this comment.
@yangryan0 Can you please comment?
| @@ -236,8 +254,7 @@ def kill(self): | |||
|
|
|||
|
|
|||
| def is_dead(self): | |||
| return self.dead | |||
|
|
|||
| return self.dead # when does this dead turns True? | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.