Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image #29

Merged
merged 1 commit into from
Dec 2, 2016
Merged

Docker image #29

merged 1 commit into from
Dec 2, 2016

Conversation

tyranron
Copy link
Contributor

This is a proposed implementation of smf-spf Docker image discussed in #23.

Features

  • alpine image is used for result image to be small.
  • s6-overlay is used as supervisor for supervising syslogd that is required for capturing logs of smf-spf.
  • nobody user is used to run smf-spf, as it's already present in image.
  • implements ability to specify configuration drop-ins in /etc/smfs/conf.d/ directory.
  • listening on inet:8890 by default, but this can be reconfigured to listen unix sockets in /var/run/smfs/ mounted directory.

To discuss

  • VERSION in Makefile. Should it be set statically, or fetched from Git tags automatically (pros/cons)?

TODO

  • Dockerfile
  • make aliases for manual image building/tagging/pushing
  • tests & upd Travic CI matrix
  • post_push Docker Hub hook generation for automated builds on GitHub
  • describe Docker stuff in README.md

@codecov-io
Copy link

codecov-io commented Nov 30, 2016

Current coverage is 63.47% (diff: 100%)

Merging #29 into master will not change coverage

@@             master        #29   diff @@
==========================================
  Files             1          1          
  Lines           460        460          
  Methods          19         19          
  Messages          0          0          
  Branches        200        200          
==========================================
  Hits            292        292          
  Misses           84         84          
  Partials         84         84          

Powered by Codecov. Last update f0540fe...61e0090

@jcbf jcbf merged commit 451d113 into jcbf:master Dec 2, 2016
@jcbf
Copy link
Owner

jcbf commented Dec 2, 2016

I'm merging this and better open different issues/pull-requests for the pending stuff

@tyranron tyranron changed the title WIP: Docker image Docker image Dec 2, 2016
@tyranron
Copy link
Contributor Author

tyranron commented Dec 2, 2016

@jcbf wow, that was accidentally.
Ok, I'll complete the stuff in separate PRs.

@tyranron tyranron deleted the 23-docker-image branch December 2, 2016 12:20
@jcbf jcbf added this to In progress in Release SPF 2.4.0 Nov 10, 2017
@jcbf jcbf removed this from In progress in Release SPF 2.4.0 Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants