Build-qt.sh fixes and updates #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmolens
commented
Jul 7, 2017
msmolens
commented
- Fix installation directory option
- Fix and enhance OS X sysroot option
- Exit when a command fails
- Avoid redownloading libraries when running multiple times, such as during testing
- Make output quieter so that errors are more apparent
- Disable phonon to support building with OS X 10.12 SDK
- Move library versions to configuration variables
Before, the script overwrote the user-specified installation directory with qt-everywhere-opensource-build-4.8.7. Now, respect the user-specified option and default to qt-everywhere-option-build-4.8.7.
Fix a bug where the default sysroot was not applied because it was assigned to a wrongly named variable. Additionally, attempt to use xcrun to determine the default SDK path before falling back to the fixed value.
Avoid redownloading libraries if the archives already exist locally.
Don't extract archives verbosely and build Qt with less output. This reduces the output to the console, which is valuable especially when running the script on a remote system.
Disable phonon to fix the following build error when building with the OSX 10.12
SDK:
../../../3rdparty/phonon/qt7/quicktimevideoplayer.h:23:9: fatal error: 'QTKit/QTDataReference.h' file not found
To keep the script simple and builds consistent, always disable phonon without
regard for the platform or SDK version.
|
@fbudin69500 Could you review this? |
|
@msmolens Looks good to me. Did you run it on travis CI? |
|
Thanks. How do I run it on TravisCI? (Shouldn't that happen automatically?) |
|
I am not sure if there is a hook. If there isn't, you can also add the hook on your personal repo of qt-easy-build, or even run it manually from travisCI |
|
It seems there are some problems with the TravisCI configuration: https://travis-ci.org/msmolens/qt-easy-build/jobs/254929715 |
|
Indeed. I had updated this repo a while back so that it would work on travisCI, but clearly it is not up to date anymore :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.