Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validate method to FisherDerivative #17

Closed
JCGoran opened this issue Nov 17, 2022 · 0 comments
Closed

Add validate method to FisherDerivative #17

JCGoran opened this issue Nov 17, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@JCGoran
Copy link
Owner

JCGoran commented Nov 17, 2022

It's possible that a user makes a typo on some parameter when calling, say, fisher_matrix, and therefore the whole computation may fail, wasting valuable time.

Proposal

Add a method called validate (or is_valid), which by default returns True, and which a user can override if they want to perform validation of the parameters before doing any computation.
As fitk only has complete control over the derivative and fisher_matrix methods, it should be implemented at that level, rather than in signal or covariance.

@JCGoran JCGoran added the enhancement New feature or request label Nov 17, 2022
@JCGoran JCGoran self-assigned this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant