Extract emoji image tag generation to own method #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
jch
added a commit
that referenced
this pull request
Jul 28, 2015
Extract emoji image tag generation to own method
|
@kbrock Thanks for the PR! @simeonwillbanks thanks for getting this on my radar again. I was out on leave so there may be some stale issues. |
|
thanks all |
jedcn
added a commit
to jedcn/reveal-ck
that referenced
this pull request
Sep 28, 2015
This is nicer because I want to use everything that EmojiFilter does *except* the image tag generation. The prior implementation had to get involved with finding emojis and gsubbing them out. This possible now because of @kbrock's change over here: gjtorikian/html-pipeline#195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The emoji support is great.
I'd like it to generate images without html attributes, but other people probably want something else.
This extracts the image tag generation into its own method so people can subclass to generate tags that work best for them.
Thanks