shutdown with timeout closes socket immediately and waits after

[flozano]

While testing pushy, I am doing (simplified version):

pushManager.start();
pushManager.enqueuePushNotification(notification);
List<ApnsPushNotification> unsent = pushManager.shutdown(3000);

I know this is not the right way to use it and that I should keep the pushManager started for much longer. I'm just testing how shutdown with timeout behaves, and it looks like a weird behavior to me:

[2013-11-19 09:08:05,252] [DEBUG] [SQSEventListener-447537958] [] [] SimplePushManagerProvider:100 Starting pushManager
[2013-11-19 09:08:05,271] [DEBUG] [SQSEventListener-447537958] [] [] SimplePushManagerProvider:103 Started pushManager
[2013-11-19 09:08:05,272] [DEBUG] [SQSEventListener-447537958] [] [] PushyAPNSSendServiceImpl:116 Sending push notification (token=f44edf678a36a3e145e0eeb489925d996aacabeefb9f6e078f0299009b515583, payload={"aps":{},"whatever":"blabla"})
[2013-11-19 09:08:05,274] [DEBUG] [SQSEventListener-447537958] [] [] SimplePushManagerProvider:57 Stopping pushManager
[2013-11-19 09:08:05,472] [DEBUG] [pool-1-thread-3] [] [] APNSMockServer:145 EOF received while reading command
[2013-11-19 09:08:05,472] [INFO] [pool-1-thread-3] [] [] APNSMockServer:241 Closing socket...
[2013-11-19 09:08:07,675] [DEBUG] [SQSEventListener-447537958] [] [] SimplePushManagerProvider:62 Stopped pushManager (unsent=[SimpleApnsPushNotification [token=f44edf678a36a3e145e0eeb489925d996aacabeefb9f6e078f0299009b515583, payload={"aps":{},"whatever":"blabla"}, expiration=null]])

I would expect it to have enough time in 3 seconds to drain the buffer, given that it contains just one notification...

[flozano]

After seeing the code, I think my expectations for shutdown with timeout don't match the implementation :)

[flozano]

What about a drainAndShutdown(long timeout) which blocks accepting new notifications and only drains the current buffer ones?
See tentative impl in #25