Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Steps: Fine tuning #46

Closed
sfarnel opened this issue Sep 16, 2020 · 11 comments
Closed

Next Steps: Fine tuning #46

sfarnel opened this issue Sep 16, 2020 · 11 comments
Assignees

Comments

@sfarnel
Copy link
Member

sfarnel commented Sep 16, 2020

These are remaining fine tuning elements to be completed before the next big chunk of work is undertaken.

Home page

(from issue #23) –
Move small canlink logo (top left corner) 5 pixels down
Add gradient background
Move U of A library to the bottom of the cloud
Eliminate any drop shadow border
(from issue #36) -
Color and font specs (specs.copy.pdf)

Search page and visualizations

(from issue #45) –
see fine tuning specs doc (fine.tuning.pdf) (except do not move search to header, do leave map as world map)
(from issue #10) –
ensure University names are not cut off
(from issue #11) –
display full degree names (if this can be done; if you need data let me know)

Once done another review for fine-tuning will be done.

@jchartrand
Copy link
Collaborator

I am really stuck on changing the colour of the selected visualization button (from it's grey colour to blue):

image

What should work (with css, pseudo classes, the material-ui overrides, etc.), isn't.

I've already spent close to a couple of hours on this - should I cut our losses and move on to something else, or stick it out?

@sfarnel
Copy link
Member Author

sfarnel commented Sep 17, 2020

Thanks @jchartrand Let's cut our losses for the moment

@jchartrand
Copy link
Collaborator

ok. otherwise, things are going well. I've just pushed up some new changes, including the Word Cloud adjustments (font, colour, horizontal word layout, alignment).

@CarlsoFiorention
Copy link
Collaborator

CarlsoFiorention commented Sep 17, 2020 via email

@jchartrand
Copy link
Collaborator

I've just pushed up some more changes that include alignment and colour for the Treemap.

@sfarnel
Copy link
Member Author

sfarnel commented Sep 18, 2020

Thanks @jchartrand Looks great! Is there a way to adjust where the number of items associated with a date appears? Currently it is below the treemap and so if you're not scrolling down you don't notice it.

@jchartrand
Copy link
Collaborator

Yes, no problem - where would you like it to appear? I've also just now adjusted the font on that number of items, and added a label to describe what the number means, and to explain that you can mouseover to get values (this is not yet pushed to server; it is only on my local dev server):

image

image

@jchartrand
Copy link
Collaborator

Moving the text from where it is now to up above the Treemap would be easy. Adding a mouseover popup instead (to show the counts in the popup) would take an hour or two.

@sfarnel
Copy link
Member Author

sfarnel commented Sep 18, 2020

Thanks @jchartrand Let's move it to above the treemap for now

@jchartrand
Copy link
Collaborator

I think this is all done now, except for issues #10 and #11 which are referenced here, but are also up in the project board.

@sfarnel
Copy link
Member Author

sfarnel commented Sep 18, 2020

Closing now. Issues 10 and 11 remain open, separately, pending data cleanup.

@sfarnel sfarnel closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants