This repository has been archived by the owner on Jul 9, 2023. It is now read-only.
Async / await cleanup #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T> methods you only need to await if you're using the or relying on the result of the task, in these cases we can simply return the task that will represent the asynchronous opertaion. Additionally, I removed some redundant "this" keywords while I was in here.
|
Thanks a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary
async/awaitkeywords. For simpleTaskandTask<T>methods you only need to await if you're using the or relying on the result of the task, in these cases we can simply return the task that will represent the asynchronous operation. Additionally, I removed some redundantthiskeywords while I was in here.Additionally, I added the "Async" suffix to one of the methods that was missing it.