Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uuid.test() for uppercased UUID returns false #17

Closed
Mesqalito opened this issue Jun 22, 2020 · 1 comment · Fixed by #18
Closed

uuid.test() for uppercased UUID returns false #17

Mesqalito opened this issue Jun 22, 2020 · 1 comment · Fixed by #18

Comments

@Mesqalito
Copy link

const id = uuid();
console.log(uuid.test(id)); // true
console.log(uuid.test(id.toUpperCase())); // false

I think treating uppercased hexadecimals as invalid aren't right. test() function's regexp should be case-insensitive.

@jchook
Copy link
Owner

jchook commented Jun 22, 2020

Yep I agree, great catch. Will push a fix.

jchook added a commit that referenced this issue Jun 22, 2020
jchook added a commit that referenced this issue Jun 22, 2020
jchook added a commit that referenced this issue Jun 24, 2020
jchook added a commit that referenced this issue Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants