Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support listening on any interface and fix threading bugs #1

Merged
merged 6 commits into from
Jun 26, 2017
Merged

Support listening on any interface and fix threading bugs #1

merged 6 commits into from
Jun 26, 2017

Conversation

BryanCrotaz
Copy link
Contributor

@BryanCrotaz BryanCrotaz commented Jun 26, 2017 •
edited
Loading

  • Listen IpAddress can now be "*"
  • Fixed bug when receiving a large message in lots of small buffers - read bytes not necessarily equal to buffer size!
  • Optimised read by reusing buffer
  • Added semaphore around server writes to stop them overlapping (semaphore per client)
  • Also supports query strings on incoming connection

@jchristn
Copy link
Owner

Thanks so much @BryanCrotaz , I'll go through these by EOD tomorrow! Appreciate your support and help on these!

@BryanCrotaz
Copy link
Contributor Author

Tested on Windows, about to test on mono on Raspberry Pi

@jchristn jchristn merged commit 8822292 into jchristn:master Jun 26, 2017
@jchristn
Copy link
Owner

Thank you @BryanCrotaz - I merged these in and created a new version (v1.1.0) due to the ClientConnected signature change - commit is here: a2a9599

And I updated NuGet with v1.1.0 as well: https://www.nuget.org/packages/WatsonWebsocket/1.1.0

Thank you very much for contributing these fixes and changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BryanCrotaz @jchristn