Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Logo and Favicon #19

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
b3f6fb8
Add files via upload
tuetenk0pp Jun 29, 2022
9f8dd53
Create generate-favicons.yml
tuetenk0pp Jun 29, 2022
4674bc9
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
0d76fbd
Add files via upload
tuetenk0pp Jun 29, 2022
4a7df04
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
2e7d57e
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
1f5cde5
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
ce9b8a4
Update realfavicongenerator.json
tuetenk0pp Jun 29, 2022
7d3db38
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
f179741
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
2069d8d
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
69b4a5f
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
59ed2fb
generated
invalid-email-address Jun 29, 2022
bfc1845
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
7992d8d
Delete realfavicongenerator.json
tuetenk0pp Jun 29, 2022
6e03189
Update logo.svg
tuetenk0pp Jun 29, 2022
f393c25
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
0f09666
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
d3d2168
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
debd59e
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
fc6c7b0
Update generate-favicons.yml
tuetenk0pp Jun 29, 2022
7821fe9
update favicons
invalid-email-address Jun 29, 2022
18b0998
add workflow badge
tuetenk0pp Jul 2, 2022
7c7b2a7
Merge branch 'jchue:main' into master
tuetenk0pp Oct 3, 2022
65d3114
remove realfavicongenerator functionality
tuetenk0pp Oct 3, 2022
2c1a7bd
png files and new workflow
tuetenk0pp Oct 3, 2022
2173ad5
fix syntax
tuetenk0pp Oct 3, 2022
2f67df7
add instructions on favicon use
tuetenk0pp Oct 3, 2022
a6de18c
use apt-get
tuetenk0pp Oct 4, 2022
0b1b5fa
issue maybe related to working directory
tuetenk0pp Oct 4, 2022
3d3e8c5
find error
tuetenk0pp Oct 4, 2022
4a652d3
inkscape version?
tuetenk0pp Oct 4, 2022
7ed5164
older inkscape: other cli
tuetenk0pp Oct 4, 2022
cdbd750
fix syntax
tuetenk0pp Oct 4, 2022
b360667
fix filenames
tuetenk0pp Oct 4, 2022
9e67418
update favicons
invalid-email-address Oct 4, 2022
9dc89d1
add open-sans
tuetenk0pp Oct 4, 2022
4fa354c
update favicons
invalid-email-address Oct 4, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 39 additions & 0 deletions .github/workflows/generate-favicons.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: Logo and Favicon Generation

on:
push:
paths:
- 'logo.svg'
workflow_dispatch:

jobs:
make-favicons:
runs-on: ubuntu-latest

steps:
- name: install inkscape and open-sans
run: |
sudo apt-get update
sudo apt-get install inkscape fonts-open-sans -y

- name: checkout code
uses: actions/checkout@v3

- name: convert files
run: |
echo 'note inkscape version'
inkscape -V
echo 'commands will only work on inkscape older than 1.0'
echo 'see this stackoverflow post for more info'
echo 'https://stackoverflow.com/a/14174624'
inkscape -z -w 180 -h 180 logo.svg -e assets/apple-touch-icon.png
inkscape -z -w 32 -h 32 logo.svg -e assets/favicon-32.png
inkscape -z -w 192 -h 192 logo.svg -e assets/favicon-192.png

- name: commit changes
run: |
git config user.name github-actions
git config user.email github-actions@github.com
git add .
git commit -m "update favicons"
git push
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
[![GitHub release (latest by date)](https://img.shields.io/github/v/release/jchue/argon-webtrees-theme)](https://github.com/jchue/argon-webtrees-theme/releases/latest)
[![webtrees major version](https://img.shields.io/badge/webtrees-v2.1.x-9cf)](https://webtrees.net/download)
![GitHub Workflow Status](https://img.shields.io/github/workflow/status/tuetenk0pp/argon-webtrees-theme/Logo%20and%20Favicon%20Generation?label=favicon%20generation)

# Argon Theme for webtrees

Expand Down Expand Up @@ -31,9 +32,11 @@ webtrees 2.1.x (see [prior releases](https://github.com/jchue/argon-webtrees-the
4. Upload the folder into the `modules_v4` directory of the webtrees installation on your web server.
5. Ensure the theme is enabled in your Control panel.

**Optional Step:** If you would like to use the alternative logo ([`logo.svg`](./logo.svg)), replace the apple-touch-icon.png and favicon-files you find in the web root and public directories with the respective files you find in the [assets directory](./assets/) in this repository.

## Structure

Because webtrees 2 is built with Bootstrap by default, the majority of this theme is just a matter of applying the Argon stylesheet.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose my editor made changes to the line endings

Because webtrees 2 is built with Bootstrap by default, the majority of this theme is just a matter of applying the Argon stylesheet.

Additionally, there are a handful of opinionated changes, mostly regarding sizing and spacing, requiring some views to be overwritten. Most of these are achieved with a simple replacement function to add/remove/modify classes and elements. Therefore, when a change is introduced in the webtrees codebase, these views should adopt them accordingly unless there is a drastic change to the template.

Expand Down Expand Up @@ -81,4 +84,4 @@ To support Sass and ECMAScript, the stylesheets and scripts are developed in the
npm run build
```

This will compile/transpile the stylsheets/scripts and package them, along with the PHP views, in a `dist/` directory.
This will compile/transpile the stylsheets/scripts and package them, along with the PHP views, in a `dist/` directory.
Binary file added assets/apple-touch-icon.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/favicon-192.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/favicon-32.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 17 additions & 0 deletions logo.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.