Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview2Loader.dll not detected #26

Closed
leaanthony opened this issue Dec 26, 2021 · 4 comments
Closed

Webview2Loader.dll not detected #26

leaanthony opened this issue Dec 26, 2021 · 4 comments

Comments

@leaanthony
Copy link
Contributor

Hey there 😄 Looks like webviewloader cannot detect WebView2Loader.dll in every scenario except if it is alongside the binary. Is that because the official DLL isn't in a default library directory? Cheers.

@jchv
Copy link
Owner

jchv commented Dec 27, 2021

In which directory are you trying to have it pick up WebView2Loader.dll from? In theory we should be getting the Standard Search Order for Desktop Applications.

@leaanthony
Copy link
Contributor Author

Yeah, I assumed that if you use NewLazyDLL("WebView2Loader.dll") it would search those paths and also assumed that "WebView2Loader.dll" would be installed in one of those paths. I mean, it's a lot of assumptions granted 😂

@jchv
Copy link
Owner

jchv commented Dec 29, 2021

Yeah, Webview2Loader won't be installed in a system directory, to my understanding; it's part of the Webview2 SDK, not the runtime. You need to have it bundled with your app. That's the main reason why go-webview2 bundles it and uses go-winloader.

Webview2Loader doesn't have a whole lot of functionality in it, though. It mainly exists to just provide the logic for finding and loading Webview2. I have reverse engineered it over here: OpenWebView2Loader.

(Addendum: go-webview2 attempts to load from disk first so that you can swap in a new binary without needing to recompile.)

@leaanthony
Copy link
Contributor Author

I think porting that to Go would be fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants