-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #2
Conversation
use the repository from @soumith since it has made cutorch optional
Looks like that version is still under active development - is it stable? |
yea the first two commits in there are stable, i'll make a separate branch that just does the cutorch-optional part. |
Done. luarocks install https://raw.githubusercontent.com/soumith/stnbhwd/cutorchoptional/stnbhwd-scm-1.rockspec (not the URL in this Pull Request) |
Thanks a bunch! Given that my pretrained models use qassemoquab/stnbhwd, will they still work if people install your fork? |
it's the same code, i just made the CUDA parts optional. Like how cunn wont compile or load if someone doesn't have GPU, stn's cuda bits wont compile or load if someone doesn't have GPU. It'll probably be merged in by Maxime by tomorrow, so you can keep things as-is! |
Awesome! I'll leave things as they are for now. |
moving cutorch out of core dependencies for this library, just needed for cudnn function
@jcjohnson the net_utils.lua has a cutorch dependency that i have just moved so it works now on my machine |
Thanks @kmader - net_utils.lua should be fixed now. |
Since https://github.com/qassemoquab/stnbhwd/pull/16 has been merged, I think this issue is resolved. |
use the repository from @soumith since it has made cutorch optional