Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2

Closed
wants to merge 2 commits into from
Closed

Update README.md #2

wants to merge 2 commits into from

Conversation

kmader
Copy link

@kmader kmader commented Apr 20, 2016

use the repository from @soumith since it has made cutorch optional

use the repository from @soumith since it has made cutorch optional
@jcjohnson
Copy link
Owner

Looks like that version is still under active development - is it stable?

@soumith
Copy link
Contributor

soumith commented Apr 21, 2016

yea the first two commits in there are stable, i'll make a separate branch that just does the cutorch-optional part.

@soumith
Copy link
Contributor

soumith commented Apr 21, 2016

Done.

luarocks install https://raw.githubusercontent.com/soumith/stnbhwd/cutorchoptional/stnbhwd-scm-1.rockspec

(not the URL in this Pull Request)

@jcjohnson
Copy link
Owner

Thanks a bunch! Given that my pretrained models use qassemoquab/stnbhwd, will they still work if people install your fork?

@soumith
Copy link
Contributor

soumith commented Apr 21, 2016

it's the same code, i just made the CUDA parts optional. Like how cunn wont compile or load if someone doesn't have GPU, stn's cuda bits wont compile or load if someone doesn't have GPU.

It'll probably be merged in by Maxime by tomorrow, so you can keep things as-is!

@jcjohnson
Copy link
Owner

Awesome! I'll leave things as they are for now.

moving cutorch out of core dependencies for this library, just needed for cudnn function
@kmader
Copy link
Author

kmader commented Apr 21, 2016

@jcjohnson the net_utils.lua has a cutorch dependency that i have just moved so it works now on my machine

@jcjohnson
Copy link
Owner

Thanks @kmader - net_utils.lua should be fixed now.

@jcjohnson
Copy link
Owner

Since https://github.com/qassemoquab/stnbhwd/pull/16 has been merged, I think this issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants