Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter numbers missing, error in nbpages.cfg, TOC links broken #44

Closed
adowling2 opened this issue Jun 3, 2020 · 9 comments
Closed

Comments

@adowling2
Copy link
Collaborator

https://ndcbe.github.io/cbe67701-uncertainty-quantification/

@adowling2
Copy link
Collaborator Author

Links are also broken.

@adowling2
Copy link
Collaborator Author

Need an extra split to construct github_user_name. A possibility is the @adowling2 checked out with ssh but @jckantor checked out with https for testing.

@adowling2
Copy link
Collaborator Author

adowling2 commented Jun 3, 2020

Need to parse username first on : to remove the protocol than / to get the username. We confirmed that @jckantor checked out with https but @adowling2 checked out with ssh.

@adowling2
Copy link
Collaborator Author

Note to self: need to check links on the table on contents too. There might still be a bug.

@adowling2 adowling2 changed the title Chapter numbers missing Chapter numbers missing, error in nbpages.cfg, TOC links broken Jun 3, 2020
@adowling2
Copy link
Collaborator Author

adowling2 commented Jun 3, 2020

I just reran with the development version of nbpages. I still think there is a mistake:
https://github.com/ndcbe/cbe67701-uncertainty-quantification/blob/159c50c0eeb00d1f176e737bce558b05e0a5a3e3/nbpages.cfg

@jckantor

@adowling2
Copy link
Collaborator Author

@jckantor I actually switched to the development branch but forgot to pull. I just pulled to the most recent version. It appears to work. Waiting for the github pages to update.

@jckantor
Copy link
Owner

jckantor commented Jun 4, 2020

I think this is working now. So close this .. reopen if there's a problem.

@jckantor jckantor closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants