This repository has been archived by the owner on Feb 4, 2019. It is now read-only.
Added motivation for the bundles module #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| This module provides convenience bundles to let jclouds run properly in OSGi environments. | ||
| Some of the bundles contained here are not publicly available, and others are just repackaged | ||
| to make them work well with jclouds. |
There was a problem hiding this comment.
Interesting question: where is this less likely to go out-of-date, do you think - in a README or as comments in the respective POM files?
As for the wording, I'd only just minor changes and a bit less detail (again, given the risk of this going out of date). Something like:
This module provides bundles required to let jclouds run in OSGi environments. These bundles here may not be publicly available elsewhere, or have been repackaged to work with jclouds.
and then move detailed comments into the POM for each bundle?
Agree with the approach of putting the details in each pom.xml and keeping the README generic. |
|
+1 - looks good to me. Thanks, @nacx! |
|
Merged to master: 522e245. Thanks, Ignasi! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should try to be very clear about the need for these bundles and why we are providing them here.
@demobox Can you have a look at the wording?