Adds support for Rackspace Cloud Big Data #78
Conversation
| * @author zack-shoylev | ||
| * | ||
| */ | ||
| public enum Status { |
There was a problem hiding this comment.
I am getting more info about what exactly goes in here.
|
jclouds » jclouds-labs-openstack #811 SUCCESS |
|
jclouds-labs-openstack-pull-requests #154 SUCCESS |
|
jclouds » jclouds-labs-openstack #813 SUCCESS |
|
jclouds-labs-openstack-pull-requests #155 SUCCESS |
|
jclouds-labs-openstack-pull-requests #156 FAILURE |
|
jclouds » jclouds-labs-openstack #818 SUCCESS |
Jenkins error, unrelated to this request. |
| * @return The current tenant. | ||
| */ | ||
| @Provides | ||
| Optional<Tenant> getCurrentTenantId(); |
There was a problem hiding this comment.
Is this actually used anywhere? Is there a use for it?
If not, just remove it.
There was a problem hiding this comment.
This is supported for other services. Unsure if it is used, though. I will remove for now.
This might have to be removed in other places as well (if actually unused).
|
Strange, it did not. I have doc warnings enabled too. |
|
jclouds » jclouds-labs-openstack #824 SUCCESS |
|
jclouds-labs-openstack-pull-requests #157 SUCCESS |
| /** | ||
| * Enumerates different types of clusters. | ||
| */ | ||
| public static enum ClusterType { |
There was a problem hiding this comment.
This whole enum should probably just be removed right?
The types of clusters will be changing relatively often and clients will be able to dynamically discover types via List Cluster Types.
There was a problem hiding this comment.
This is correct! However to make this PR more testable I have included it for now.
Ho about removing it when the Cluster Type feature is added?
|
@zack-shoylev Good work on the code here but can you please give the Javadoc some more love? Look at it from the perspective of a user who knows little about big data and nothing about jclouds. The class level Javadoc should be extra descriptive. Please double check every single line of Javadoc for accuracy and descriptiveness. |
|
|
||
| /** | ||
| * The API for controlling profiles. | ||
| * Your Cloud Big Data profile is different from your cloud account. Your profile has the following characteristics and requirements: |
There was a problem hiding this comment.
Well this is just flat out wrong. :P
|
jclouds » jclouds-labs-openstack #828 SUCCESS |
|
jclouds-labs-openstack-pull-requests #158 SUCCESS |
|
I will add some more Javadoc love to the PR. There are some doc questions I need to ask the big data team first though before I can finish with the doc update. |
|
jclouds » jclouds-labs-openstack #829 SUCCESS |
|
jclouds-labs-openstack-pull-requests #159 SUCCESS |
| <enabled>true</enabled> | ||
| </snapshots> | ||
| </repository> | ||
| </repositories> |
There was a problem hiding this comment.
The snapshots repo is already defined in jclouds-project.
There was a problem hiding this comment.
I think the problem here is that, if you check out only the labs-openstack repo, you need to get jclouds-project. If you don't have this snapshot repo, it won't work ;-)
There was a problem hiding this comment.
Ah I see, you also need the repo to get the parent pom. Forget my comment then :) I didn't notice!
|
jclouds » jclouds-labs-openstack #835 SUCCESS |
|
jclouds-labs-openstack-pull-requests #160 SUCCESS |
|
jclouds » jclouds-labs-openstack #839 SUCCESS |
|
jclouds-labs-openstack-pull-requests #161 SUCCESS |
|
The Javadoc can always be updated in later PRs. No need to block merging on Javadoc at this point in time. |
|
This seems to be code-complete. Remaining documentation todos will be updated later as that documentation becomes more available. Rebasing and merging. |
|
jclouds » jclouds-labs-openstack #843 SUCCESS |
|
jclouds-labs-openstack-pull-requests #162 SUCCESS |
|
merged |
|
jclouds » jclouds-labs-openstack #844 SUCCESS |
|
jclouds-labs-openstack-pull-requests #163 SUCCESS |
This starts work on Cloud Big Data. More features to be implemented.