[JCLOUDS-500] Initial commit for docker #57
Conversation
|
jclouds-labs-pull-requests #136 SUCCESS |
|
jclouds » jclouds-labs #886 FAILURE |
| <!-- TODO: when out of labs, switch to org.jclouds.provider --> | ||
| <groupId>org.apache.jclouds.labs</groupId> | ||
| <artifactId>docker</artifactId> | ||
| <version>1.8.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Don't think we need this since we're inheriting from the labs parent POM?
GitHub timeout |
| </profile> | ||
| </profiles> | ||
|
|
||
| </project> |
|
jclouds » jclouds-labs #1150 SUCCESS |
|
jclouds-labs-pull-requests #175 SUCCESS |
|
jclouds-labs-pull-requests #176 SUCCESS |
|
jclouds » jclouds-labs #1158 SUCCESS |
| /** | ||
| * Provides synchronous access to Docker Remote API. | ||
| * | ||
| * @see <a href="http://docs.docker.io/en/latest/api/docker_remote_api_v1.8/#docker-remote-api-v1-8"></a> |
There was a problem hiding this comment.
The link points to version 1.8 but the api metadata uses version 1.11. Change all links accordingly or just point to a root location that does not contain the version in the URL?
|
Thanks @andreaturli! All the points in the checklist have been addressed, and I think it is almost ready to be merged. Could you address the last comments? (Don't forget about this one and this one). |
|
jclouds » jclouds-labs #1208 SUCCESS |
|
jclouds-labs-pull-requests #184 SUCCESS |
|
Here you can find the result of unfortunately there are still issue with the DockerComputeServiceLiveTest but I think it is good to be accepted on jclouds-labs at least and fix liveTests there, if you agree |
|
jclouds-labs-pull-requests #202 UNSTABLE |
|
jclouds » jclouds-labs #1242 UNSTABLE |
|
jclouds-labs-pull-requests #203 SUCCESS |
|
jclouds » jclouds-labs #1243 SUCCESS |
|
jclouds-labs-pull-requests #204 SUCCESS |
|
jclouds » jclouds-labs #1244 SUCCESS |
| } | ||
|
|
||
| public TemplateOptions cpuShares(int cpuShares) { | ||
| checkNotNull(cpuShares, "cpuShares was null"); |
There was a problem hiding this comment.
Why do you do the checkNotNull then create an Optional? In fact, since this is a primitive, it cannot ever be null. If we want the null semantics, change to the following (and see also memory, plus dns and hostname which are strings, so could be null...)
public TemplateOptions cpuShares(@Nullable Integer cpuShares) {
this.cpuShares = Optional.fromNullable(cpuShares);
return this;
}There was a problem hiding this comment.
thanks @grkvlt, much cleaner
|
jclouds » jclouds-labs #1258 SUCCESS |
|
jclouds-labs-pull-requests #205 SUCCESS |
|
Rebased and merged. Huge thanks @andreaturli! |
|
great @nacx! Thanks again for your valuable reviews |
No description provided.