Skip to content
This repository has been archived by the owner on Feb 4, 2019. It is now read-only.

Update compute.md #130

Closed
wants to merge 1 commit into from
Closed

Update compute.md #130

wants to merge 1 commit into from

Conversation

yaronr
Copy link
Contributor

@yaronr yaronr commented Oct 1, 2014

It's called 'client' and not 'computeService' throughout the rest of the examples, so this is slightly confusing

It's called 'client' and not 'computeService' throughout the rest of the examples, so this is slightly confusing
@cloudbees-pull-request-builder

jclouds-site-pull-requests #402 SUCCESS
This pull request looks good

@jclouds-commentator
Copy link

@etoews
Copy link
Member

etoews commented Oct 6, 2014

Thanks for the sharp eyes @yaronr!

I think it's more than slightly confusing considering there are also examples on this page that use client to refer to a SshClient.

Instead of renaming the ComputeService var to client, would you be willing to rename all of the other ComputeService references to computeService?

@yaronr
Copy link
Contributor Author

yaronr commented Oct 6, 2014

Sure :)

(Y)

On Oct 6, 2014, at 9:47 PM, Everett Toews notifications@github.com wrote:

Thanks for the sharp eyes @yaronr!

I think it's more than slightly confusing considering there are also examples on this page that use client to refer to a SshClient.

Instead of renaming the ComputeService var to client, would you be willing to rename all of the other ComputeService references to computeService?


Reply to this email directly or view it on GitHub.

@etoews
Copy link
Member

etoews commented Mar 24, 2015

Thanks for the pull request but it's release week in jclouds and that means it's time to clean up the PR queue. This PR will be over 6 months old as of April 1. If you intend to continue work on it, please make a comment by April 2. Otherwise it will be closed on April 3.

@jclouds-commentator
Copy link

@etoews
Copy link
Member

etoews commented Apr 3, 2015

Merged.

@etoews etoews closed this Apr 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants