Flatten children with React.Children.toArray upfront #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolritter
force-pushed
the
fix_single_child
branch
2 times, most recently
from
b6f5c87
to
aac75a3
Compare
resolritter
changed the title
resolritter
commented
Sep 5, 2020
Closed
- useful for the single child case, where React will turn it into [child] - useful for JSX expressions which map over a data structure, because React.Children.toArray will flatten everything
resolritter
force-pushed
the
fix_single_child
branch
from
aac75a3
to
f24a1df
Compare
React.toChildrenArray should take care of that
|
@jcmcneal to be clear, do you want me to merge it myself or will you do it? |
jcmcneal
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://reactjs.org/docs/react-api.html#reactchildrentoarray
closes #65: in the single child case, where React will turn it into [child]
closes #62: on nested JSX expressions which map over a data structure, React.Children.toArray will flatten everything into a single list of children