Fix basic auth backend tracking #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic auth users and passwords are stored in secret resources. We're properly tracking secret->userlist in the event of a secret update, and backends are also tracked but only when a new userlist is created. A proper partial parsing need to track either a host or a backend from the haproxy model. If an untracked backend uses a tracked userlist, changes to this userlist will remove it without recreate, which will lead to failures in the configuration parsing. This update enforces that a backend is always tracked in the event of a secret update, ensuring that partial parsing works properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic auth users and passwords are stored in secret resources. We're properly tracking secret->userlist in the event of a secret update, and backends are also tracked but only when a new userlist is created.
A proper partial parsing need to track either a host or a backend from the haproxy model. If an untracked backend uses a tracked userlist, changes to this userlist will remove it without recreate, which will lead to failures in the configuration parsing.
This update enforces that a backend is always tracked in the event of a secret update, ensuring that partial parsing works properly.