Add warning if auth external svc isnt found #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcmoraisjr
force-pushed
the
jm-auth-external-svc-warn
branch
from
126c64c
to
1396116
Compare
didiercolens
reviewed
Feb 7, 2023
Auth External works by parsing the authentication service url and looking for a pre-configured backend. The pre-configuration part works by making a normalization in the k8s service port number, so different inputs for the same service will output the same backend. This might change the port name of the backend on named port configurations. A proper fix is to make the backend creation accessible by the updater code, so we don't need to pre-initialize the backend in the ingress step, and don't need to guess the backend port name in the updater step. So, for now, we'll improve logging and documentation. This should be merged as far as v0.13, which implements the first version of auth external.
jcmoraisjr
force-pushed
the
jm-auth-external-svc-warn
branch
from
1396116
to
cf8a58b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth External works by parsing the authentication service url and looking for a pre-configured backend. The pre-configuration part works by making a normalization in the k8s service port number, so different inputs for the same service will output the same backend. This might change the port name of the backend on named port configurations.
A proper fix is to make the backend creation accessible by the updater code, so we don't need to pre-initialize the backend in the ingress step, and don't need to guess the backend port name in the updater step. So, for now, we'll improve logging and documentation.
This should be merged as far as v0.13, which implements the first version of auth external.