help support reinstated #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: libvdev/config.c modified: libvdev/config.h modified: vdevd/main.c modified: vdevd/vdev.c patches to (re)instate --help for the vdevd daemon. should now exit early when -h or --help is supplied on the command line. hopefully I have understood the project style and intent of various code structures. currently the exit code is 2 make clean make test and compare with build/sbin/vdevd -l mylogfile.log -h echo $? =returns=> 6 build/sbin/vdevd --help echo $? =returns=> 2 which may be a little helpful There are structures and defs for future work
set CFLAGS to more recent C version and increase error reporting originals simply commented out ready for production uses.
Some small tweaks for clarity and consistancy with init time errors.
No major alterations diff maybe becuase of testing.
modified: libvdev/config.c modified: libvdev/ini.c modified: libvdev/ini.h modified: libvdev/param.h modified: libvdev/sglib.h modified: libvdev/util.h modified: vdevd/action.c modified: vdevd/vdev.c modified: vdevd/vdev.h Mostly just compiler warning fixits. - attempts to understand some macros and defs. - attempts to understand initramfs inplications. - No functionality alters at all.
|
These were the result of some explorations and testing I did. |
no more than a style tidy up.
also some hand tweaks all cosmetics only
just for the blast
Moving everything to GNU style As a "middle path"... Its probaly appropriate to move LINUX specific code to -linux style... Not a huge issue for me.
ralph.ronnquist@gmail.com
capturing a snapshot for dev and emergency uses This version has been slightly extended to warn about possible accidental creations.
Some tidy ups and gentle extensions Most important change is to ensure i386 build of initramfs (libc naming conventions ?)
|
hi why this pull request was not merged? |
|
I'm wondering the same thing |
mckaygerhard
reviewed
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patches to (re)instate --help for the vdevd daemon.
should now exit early when -h or --help
is supplied on the command line.
hopefully I have understood the project style
and intent of various code structures.
currently the exit code is 2
That value is pure opinion on my part
and possibly accidental as that's what I tend to use in scripts.
make clean
make
test and compare with
build/sbin/vdevd -l mylogfile.log -h
echo $? =hopefully returns=> 6
build/sbin/vdevd --help
echo $? =hopefully returns=> 2
which may be a little helpful
There are structures and defs for future work
I followed the existing code base as closely as I could.
Apologies
As a bonus my .gitignore has been included .
this may or may not cause hurt.
I will attempt to tame my git.