Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Dependencies #37

Closed
wants to merge 3 commits into from

Conversation

colem213
Copy link

@colem213 colem213 commented Jan 27, 2020

The latest version of the mkdirp dependency (1.0.3) causes a invalid options argument when running the cli with something like canopy test.peg.

This PR will lock the dependency to the latest working versions I was able to find on my machine. It seems that only mkdirp is the problem though.

@colem213 colem213 requested a review from jcoglan January 28, 2020 03:03
@swappysh
Copy link

Can use force resolution to temporarily fix this https://github.com/rogeriochaves/npm-force-resolutions/

@colem213
Copy link
Author

@swappysh Thanks, I was looking for something like that. When I didn't find it I just published with my changes.
https://www.npmjs.com/package/@colem213/canopy

@jcoglan
Copy link
Owner

jcoglan commented Feb 15, 2020

@colem213 If the problem is with mkdir_p specifically, can you revise this PR so that it either:

  • locks the version of mkdir_p using an upper bound (<=) and makes no other changes
  • fixes the bug in our use of mkdir_p and set a lower bound only (>=) on its version

It's not clear why any of the other dependencies have been locked, or why these versions have been picked. Pull requests should not modify the package's version field.

@longhotsummer
Copy link
Contributor

I've submitted #38

Copy link

@nmorse nmorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should fix error using mkdir

@jcoglan
Copy link
Owner

jcoglan commented Aug 3, 2020

This problem has now been fixed by merging #38.

@jcoglan
Copy link
Owner

jcoglan commented Apr 1, 2022

This should now be fixed as part of the v0.4 release; see https://blog.jcoglan.com/2022/04/01/announcing-canopy-0-4/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants