Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binder badge #30

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Fix binder badge #30

merged 3 commits into from
Jan 9, 2023

Conversation

po09i
Copy link
Collaborator

@po09i po09i commented Dec 1, 2022

The binder badge has been broken. Binder seems to have switched some default behaviour at the beginning of 2022 which coincides with then we observed the problem. This thread discusses it in more detail. The fix specifies in the path to use the old behaviour.

@po09i
Copy link
Collaborator Author

po09i commented Dec 1, 2022

@sandrinebedard Can you test if the badge now works for you

Copy link
Owner

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently testing-- after 20 minutes it is still loading:
image

Copy link
Owner

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and after 25 min it failed:

image

@sandrinebedard
Copy link
Collaborator

It loaded in 2 seconds for me!

image

@jcohenadad
Copy link
Owner

ok let me try again

@jcohenadad
Copy link
Owner

It loaded in 2 seconds for me!

I'm a bit suspicious about the 2 seconds because conda needs to be installed, and then all deps need to be downloaded and installed. Even locally it takes at least 30s or more, no? Is it possible that it was using a cached version of MyBinder in your browser?

@sandrinebedard
Copy link
Collaborator

It loaded in 2 seconds for me!

I'm a bit suspicious about the 2 seconds because conda needs to be installed, and then all deps need to be downloaded and installed. Even locally it takes at least 30s or more, no? Is it possible that it was using a cached version of MyBinder in your browser?

That's what I am thinking too! But I never managed to load it before, that's why I am also suspicious ... I am testing it in a private browsing tab too.

@jcohenadad
Copy link
Owner

Another try, resulting in an error after 25 minutes:
image

(also in private browsing tab).

I suggest asking other students in the lab to run it and get feedback.

@po09i
Copy link
Collaborator Author

po09i commented Dec 1, 2022

I also ran into problems... (It hung there for 15 minutes)

Screen Shot 2022-12-01 at 12 01 15 PM

@sandrinebedard
Copy link
Collaborator

on the private browsing tab, it took 15 mins to load and works now!

@gaspardcereza
Copy link
Contributor

gaspardcereza commented Dec 1, 2022

I tried it in incognito mode and it only took about 10s. I executed some cells in lab 3 and everything behaves as expected. Maybe binder just got very very good at creating environments quickly, but that would not explain why it fails on your end...

From what I recall, Binder does not always use the same hosting service, maybe that's part of the explanation.

@po09i
Copy link
Collaborator Author

po09i commented Dec 1, 2022

I tried a few things, notably installing jupiter lab instead. It seems more reliable now.. I was previously able to replicate Julien's error and now it seems to work pretty reliably when building from scratch, in private windows and in non private windows. When it does not work, I just reload the page and it usually works the 2nd time.

@po09i
Copy link
Collaborator Author

po09i commented Dec 1, 2022

Binder seems to have issues when using an adblocker, we might want to suggest to turn it off in the README.

@jcohenadad
Copy link
Owner

jcohenadad commented Dec 1, 2022

we're making progress 🎉 it worked for me (4min of loading):
image

i'm just afraid their servers are unreliable, but who knows... 🤷

Copy link
Collaborator

@sandrinebedard sandrinebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked for after 1min 43 s on a private browser page!

@po09i po09i merged commit 2fc0a44 into master Jan 9, 2023
@po09i po09i deleted the ad/fix-binder branch January 9, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants