-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix binder badge #30
Fix binder badge #30
Conversation
@sandrinebedard Can you test if the badge now works for you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok let me try again |
I'm a bit suspicious about the 2 seconds because conda needs to be installed, and then all deps need to be downloaded and installed. Even locally it takes at least 30s or more, no? Is it possible that it was using a cached version of MyBinder in your browser? |
That's what I am thinking too! But I never managed to load it before, that's why I am also suspicious ... I am testing it in a private browsing tab too. |
on the private browsing tab, it took 15 mins to load and works now! |
I tried it in incognito mode and it only took about 10s. I executed some cells in lab 3 and everything behaves as expected. Maybe binder just got very very good at creating environments quickly, but that would not explain why it fails on your end... From what I recall, Binder does not always use the same hosting service, maybe that's part of the explanation. |
I tried a few things, notably installing jupiter lab instead. It seems more reliable now.. I was previously able to replicate Julien's error and now it seems to work pretty reliably when building from scratch, in private windows and in non private windows. When it does not work, I just reload the page and it usually works the 2nd time. |
Binder seems to have issues when using an adblocker, we might want to suggest to turn it off in the README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked for after 1min 43 s on a private browser page!
The binder badge has been broken. Binder seems to have switched some default behaviour at the beginning of 2022 which coincides with then we observed the problem. This thread discusses it in more detail. The fix specifies in the path to use the old behaviour.