Merge pull request #20 from jcollado/landscape-strictness-veryhigh

Landscape strictness veryhigh

.landscape.yml

@@ -1,6 +1,6 @@
 doc-warnings: true
 test-warnings: true
-strictness: high
+strictness: veryhigh
 max-line-length: 80
 requirements:
     - requirements/common.txt

rabbithole/batcher.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-"""Batcher: group messages in batches before sending them to the output
+"""Batcher: group messages in batches before sending them to the output.
 
 The strategy to batch messages is:
     - store them in memory as they are received

rabbithole/cli.py

@@ -33,7 +33,7 @@
 
 def main(argv=None):
     # type: (List[str]) -> int
-    """Console script for rabbithole
+    """Console script for rabbithole.
 
     :param argv: Command line arguments
     :type argv: list(str)
@@ -71,7 +71,7 @@ def main(argv=None):
 
 def create_block_instance(block):
     # type: (Dict[str, Any]) -> object
-    """Create block instance from its configuration
+    """Create block instance from its configuration.
 
     :param block: Block configuration
     :type block: dict(str)

setup.py

@@ -1,23 +1,25 @@
 #!/usr/bin/env python
 # -*- coding: utf-8 -*-
 
+"""Project global configuration."""
+
 from setuptools import setup
 from setuptools.command.test import test as TestCommand
 
 with open('README.rst') as readme_file:
-    readme = readme_file.read()
+    README = readme_file.read()
 
 with open('HISTORY.rst') as history_file:
-    history = history_file.read()
+    HISTORY = history_file.read()
 
-requirements = [
+REQUIREMENTS = [
     'PyYAML',
     'blinker',
     'pika',
     'sqlalchemy',
 ]
 
-test_requirements = [
+TEST_REQUIREMENTS = [
     'coveralls',
     'mock',
     'pytest',
@@ -26,12 +28,17 @@
 
 
 class PyTest(TestCommand):
+
+    """Command to run test cases through pytest."""
+
     def finalize_options(self):
+        """Set custom argumengs fro pytest."""
         TestCommand.finalize_options(self)
         self.test_args = []
         self.test_suite = True
 
     def run_tests(self):
+        """Execute pytest with custom arguments."""
         # import here, cause outside the eggs aren't loaded
         import pytest
         pytest.main(self.test_args)
@@ -40,7 +47,7 @@ def run_tests(self):
     name='rabbithole',
     version='0.2.0',
     description="Store messages from an AMQP server into a SQL database",
-    long_description=readme + '\n\n' + history,
+    long_description=README + '\n\n' + HISTORY,
     author="Javier Collado",
     author_email='javier@gigaspaces.com',
     url='https://github.com/jcollado/rabbithole',
@@ -55,7 +62,7 @@ def run_tests(self):
         ]
     },
     include_package_data=True,
-    install_requires=requirements,
+    install_requires=REQUIREMENTS,
     license="MIT license",
     zip_safe=False,
     keywords='rabbithole',
@@ -70,6 +77,6 @@ def run_tests(self):
         'Programming Language :: Python :: 3.5',
     ],
     test_suite='tests',
-    tests_require=test_requirements,
+    tests_require=TEST_REQUIREMENTS,
     cmdclass={'test': PyTest},
 )

tests/cli/test_create_flow.py

@@ -41,7 +41,7 @@ def fixture_kwargs(input_block, output_block):
 
 
 def test_signals_connected(input_block, output_block, kwargs):
-    """Signals are connected as expected."""
+    """Signal objects are connected as expected."""
     input_signal = input_block()
     output_cb = output_block()