Skip to content

Commit

Permalink
Disable pylint broad-except error
Browse files Browse the repository at this point in the history
Exception is caught just for logging purposes and then `sys.exit` is
called, so in this case it's ok, since the goal is indeed to catch all
exceptions.
  • Loading branch information
Javier Collado committed Jan 20, 2017
1 parent 7f18fdc commit d92aae0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions rabbithole/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def create_block_instance(block):
*block.get('args', []),
**block.get('kwargs', {})
)
except Exception:
except Exception: # pylint:disable=broad-except
LOGGER.error(traceback.format_exc())
LOGGER.error(
'Unable to create %r block: (type: %r, args: %r, kwargs: %r)',
Expand Down Expand Up @@ -120,7 +120,7 @@ def create_flow(flow, namespace, batcher_config):
*input_block.get('args', []),
**input_block.get('kwargs', {})
)
except Exception:
except Exception: # pylint:disable=broad-except
LOGGER.error(traceback.format_exc())
LOGGER.error(
'Unable to get signal from %r block: (args: %r, kwargs: %r)',
Expand All @@ -137,7 +137,7 @@ def create_flow(flow, namespace, batcher_config):
*output_block.get('args', []),
**output_block.get('kwargs', {})
)
except Exception:
except Exception: # pylint:disable=broad-except
LOGGER.error(traceback.format_exc())
LOGGER.error(
'Unable to get callback from %r block: (args: %r, kwargs: %r)',
Expand Down

0 comments on commit d92aae0

Please sign in to comment.