Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-configure when projects use Elm 0.19 vs 0.18 #141

Closed
purcell opened this issue Oct 2, 2018 · 8 comments
Closed

Auto-configure when projects use Elm 0.19 vs 0.18 #141

purcell opened this issue Oct 2, 2018 · 8 comments

Comments

@purcell
Copy link
Collaborator

purcell commented Oct 2, 2018

As detailed in #138 (comment), it's now largely possible to configure elm-mode for Elm 0.19 projects, but it would probably be better if this were auto-detected. In fact, the presence of elm.json vs elm-package.json should be enough of a clue in most cases.

(Noting this here for future implementation by myself or another contributor.)

@purcell purcell changed the title Auto-configure according to project using Elm 0.19 vs 0.18 Auto-configure when projects use Elm 0.19 vs 0.18 Oct 3, 2018
@saurabhnanda
Copy link

I've spent the last 2-3 hours trying to get elm-mode working with my 0.19 project properly, but haven't been successful. Here's what I tried:

  • Upgraded spacemacs packages to get the latest version of elm-mode and flycheck-elm
  • Tried customising the following variables in ~/.spacemacs file, as well as .dir-locals.el as mentioned at repl does not load after upgrading to elm 0.19 #138 (comment)
    • elm-compile-command
    • elm-interactive-command
    • elm-package-command
    • elm-reactor-command
  • Tried setting the command/s to absolute paths, eg. <home-dir>/.nvm/versions/node/v10.4.0/bin/elm
  • Tried setting my default NVM to 10.4.0 (it was 6.11.1 earlier). Confirmed that a new bash / terminal is using nvm 10.4.0
        v6.11.1
         v8.2.1
->      v10.4.0
         system
default -> v10.4.0
node -> stable (-> v10.4.0) (default)
stable -> 10.4 (-> v10.4.0) (default)
iojs -> N/A (default)
lts/* -> lts/carbon (-> N/A)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.14.2 (-> N/A)
lts/carbon -> v8.11.2 (-> N/A)
  • Tried uninstalling 0.18 via npm uninstall elm@0.18
  • Tried physically removing the elm-make, elm-package, elm-repl and elm-reactor from ~/.nvm/versions/node/v10.4.0/bin

Nothing worked. My brain is fried.

Any help would be appreciated.

@purcell
Copy link
Collaborator Author

purcell commented Oct 20, 2018

Please can you be more specific than "nothing worked"? What steps did you follow, what did you expect, and what happened instead?

@danieljaouen
Copy link

Should we expect company-elm to not work until this is resolved?

@purcell
Copy link
Collaborator Author

purcell commented Jan 12, 2019

Should we expect company-elm to not work until this is resolved?

Yes, correct. See #142 for the completion-specific side of things. It's not pretty.

@danieljaouen
Copy link

I don't know if you get this often or not, but I just wanted to thank you for your hard work and dedication for working on this project. The whole elm-oracle debacle looks like a mess and I am super glad that there is someone on the other side of things willing to tackle problems like these. :-)

@purcell
Copy link
Collaborator Author

purcell commented Jan 12, 2019

Thanks, I appreciate it, but I should also caution that I haven't concretely tackled it yet. :-) It was frustrating to get elm-oracle completion working so nicely with 0.18 only to have it break.

@danieljaouen
Copy link

Nevertheless, it is a noble effort. I don't have much in the way of finances to remunerate you for your hard work, but I figured a word of encouragement wouldn't hurt. :-)

@purcell
Copy link
Collaborator Author

purcell commented Jan 26, 2020

The 0.19 config is now the default. I no longer plan to pursue auto-configuration for older Elm versions.

@purcell purcell closed this as completed Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants