Missing Cache Control Headers

[aselbie]

The lack of cache control headers on the main background image is causing Chrome to reload that image on every page.

[jcoppieters]

I agree. And even more important if you know that Cody caches these (static) images in memory, so they can't change anyway as long as they are in the ram cache (until they get thrown out - or the server is restarted)

Care to make me the examples / tell me what to do? I'll incorporate it in the static server (images, javascript and css files) asap.

Johan C.

[aselbie]

Well, I've never had to mess with it before, because I believe the default settings in Apache/nginx send them. But based on http://www.mobify.com/blog/beginners-guide-to-http-cache-headers/ I would think updating like so would work:

self.response.writeHead(200, { "Content-Type": type });

in Static.js would become

self.response.writeHead(200, { 
    "Content-Type": type,
    "Cache-Control": "public, max-age=86400"
});

86,400 being one day in seconds. So you could play with that depending on how long you would like your images to be cached.

[pvencill]

Ideally that max-age is something you'd set in the site config.

[jcoppieters]

Ok fixed and pushed to Git.
I've added the "Cache-Control" header in the static and dynamic file server. Defaults resp. 1 day and 10 minutes. Times both already in a variable, but this should come from a config.js/json file at the start of an application.