Cannot add songs with " ' " in their filenames

[Emilot]

Describe the bug
Cannot add songs with " ' " in their filenames

To Reproduce
Steps to reproduce the behavior:

1. Go to Search tab
2. Click on a song that has " ' " in the name(for ex. Don't go)
3. See error

Expected behavior
To be added at queue

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browser Firefox
• Version latest

[jcorporation]

Does it work, if you click on the song title?

[Emilot]

If i click on the song title it will be added successfully.

[jcorporation]

Thanks for your confirmation. I think I found the bug

[Emilot]

👍

[jcorporation]

Should now be fixed in devel. Can you test it?

[Emilot]

SyntaxError: JSON.parse: unterminated string at line 1 column 133 of the JSON data[Learn More] mympd.min.js:121:1
showMenu/</<
http://192.168.0.206/js/mympd.min.js:121:1

Same error jc...

[Emilot]

var cmd = JSON.parse(dh.replace(/'/g, '"'));

If i replace minified with normal js the Web Console indicate this line when i hit "Append to queue".

I do not know if it helps somewhere.

[Emilot]

Oh you have another one here:

el.addEventListener('shown.bs.popover', function(event) {
    document.getElementsByClassName('popover-content')[0].addEventListener('click', function(event) {
        event.preventDefault();
        event.stopPropagation();
        if (event.target.nodeName == 'A') {
            var dh = event.target.getAttribute('data-href');
            if (dh) {
                **var cmd = JSON.parse(dh.replace(/\'/g, '"'));**

[jcorporation]

var cmd = JSON.parse(dh);
is here right. But this doesn't fix the bug.
It seems that saving the ouptut of JSON.stringify can't be saved in a data-* attribute in the dom, if it contains ' or " characters in values.

Encoding the output in base64 works. I commited the fix in devel.

[Emilot]

Perfect jc

Case closed!

Thank you.

[ideonaudio]

Hi JC,

Is this the same issue?

I tried to add an album with " ' " in title... Sgt. Pepper's - Beatles

[jcorporation]

Is an another issue, please open a new issue and attach debug logs of myMPD and verbose logs of mpd. If JavaScript errors occurs these also.