Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mympd should be system user & group instead of normal user & group #51

Closed
CultofRobots opened this issue Sep 12, 2018 · 1 comment
Closed
Labels
bug Something isn't working
Milestone

Comments

@CultofRobots
Copy link

add "-r" or "--system" to lines 54 & 56 in mkrelease.sh
54: [ "$?" = "2" ] && sudo groupadd -r mympd
56: [ "$?" = "2" ] && sudo useradd -r -g mympd -d /var/lib/mympd -s /usr/sbin/nologin mympd

From an organizational standpoint it's better to use a system account for a service as opposed to a normal user account. Will also keep mympd out of the login dialog.

from the man page:

-r, --system
Create a system account.

System users will be created with no aging information in /etc/shadow, and their numeric identifiers are chosen in the SYS_UID_MIN-SYS_UID_MAX range, defined in /etc/login.defs,
instead of UID_MIN-UID_MAX (and their GID counterparts for the creation of groups).

Note that useradd will not create a home directory for such a user, regardless of the default setting in /etc/login.defs (CREATE_HOME). You have to specify the -m options if you want
a home directory for a system account to be created.

@jcorporation jcorporation added the bug Something isn't working label Sep 12, 2018
@jcorporation jcorporation added this to the v4.1.1 milestone Sep 12, 2018
@jcorporation
Copy link
Owner

Fixed in devel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants