Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
line_wrap
field to theEncodeConfig
struct that determines the line length for the encoding.Unfortunately this is a breaking change. To avoid it being a breaking change in the future, I made the fields private and added chain-able setter methods. Adding fields going forward would not be a breaking change, just a new feature.
After writing this, I came up with another idea that would avoid a breaking change. I could create a
struct Encoder
that essentially has the same state asEncodeConfig
but private.Encoder::encode(&self, &pem)
could handle encoding a PEM with the specified config without requiring any changes to the existingencode
function orEncodeConfig
struct.I can put up a separate MR with that change if that is better, or if you'd like to compare.
Resolves #48