Support arbitrarily nested NewType/ Annotated types
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for nesting `Annotated`/`NewType` wrappers in any combination. Previously you could only nest: - `Annotated[Annotated[...], ...]` (the `Annotated` constructor automatically flattens this, no need for `msgspec` to handle this case. - `Annotated[NewType(...), ...]` It also refactors the type processing code in `_core.c` to be a little cleaner (still not "clean", Python type annotations aren't the easiest objects to consume).
jcrist
changed the title
json.schema of NewTypeNewType/ Annotated types
|
Thanks for this PR! I've fixed up the remaining issues. Merging. I suspect it will be a few weeks before the next release. In the meantime you can use the workaround I posted in the corresponding issue, or install from github: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably fixes #271