Rename default to enc_hook
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kwarg name `default` was used to match that of existing apis (e.g. `json.dumps`). However, I don't think it's the best name (`default` to me implies a static value, not a callable). Since we already have `ext_hook` and I want to add `dec_hook` for custom typed decoders, renaming to `enc_hook` makes the most sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kwarg name
defaultwas used to match that of existing apis (e.g.json.dumps). However, I don't think it's the best name (defaulttome implies a static value, not a callable). Since we already have
ext_hookand I want to adddec_hookfor custom typed decoders,renaming to
enc_hookmakes the most sense.