Include the struct type in frozen hash implementation #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the provided hash method to also include the struct type.
This improves hash quality for mappings or sets that contain multiple
different struct types as keys, as structs of different types with the
same data will now hash differently, better matching the `__eq__`
implementation.
As an implementation detail, structs should now hash as a tuple of the
type and all following elements.
```python
from msgspec import Struct
class Point(Struct, frozen=True):
x: int
y: int
assert hash(Point(1, 2)) == hash((Point, 1, 2))
```
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the provided hash method to also include the struct type. This improves hash quality for mappings or sets that contain multiple different struct types as keys, as structs of different types with the same data will now hash differently, better matching the
__eq__implementation.As an implementation detail, structs should now hash as a tuple of the type and all following elements.
Addresses part of #591.