Plug leak of "match_args" in StructMeta. #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"match_args" is set in StructMetaInfo and eventually StructMeta via - ``` info->match_args = PyTuple_GetSlice(info->fields, 0, nfields - nkwonly); ``` This is incref'd before copying to StructMeta, and decref'd when cleaning up StructMetaInfo. There's no corresponding decref for StructMeta itself. This causes a leak that valgrind readily detects: ``` env PYTHONMALLOC=malloc valgrind python3 -c 'import msgspec' ... ==576283== LEAK SUMMARY: ==576283== definitely lost: 1,608 bytes in 26 blocks ``` With the fix in place, we get: ``` ==576086== LEAK SUMMARY: ==576086== definitely lost: 0 bytes in 0 blocks ```
|
Thank you for the fast response and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"match_args" is set in StructMetaInfo and eventually StructMeta via -
This is incref'd before copying to StructMeta, and decref'd when cleaning up StructMetaInfo. There's no corresponding decref for StructMeta itself. This causes a leak that valgrind readily detects:
With the fix in place, we get: