Reduce module state lookup in hot paths #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking up the module state is generally pretty quick, but if done in a hot path (e.g. encoding/decoding when not raising an exception) it can add up. We now store a reference to the module state on the encoder, which reduces the cost of serializing `enum.Enum` objects by 20-30%, and negligibly improves a few other encode paths. We also micro-optimize a few other places where we access the module state. This could be done on the decoder as well, but (almost) all access in the decoder is for raising errors and so wouldn't improve performance in common hot paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking up the module state is generally pretty quick, but if done in a
hot path (e.g. encoding/decoding when not raising an exception) it can
add up. We now store a reference to the module state on the encoder,
which reduces the cost of serializing
enum.Enumobjects by 20-30%, andnegligibly improves a few other encode paths. We also micro-optimize a
few other places where we access the module state. This could be done on
the decoder as well, but (almost) all access in the decoder is for
raising errors and so wouldn't improve performance in common hot paths.