Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making rule input more user-friendly #77

Open
kyuhyongpark opened this issue Mar 26, 2022 · 3 comments
Open

Making rule input more user-friendly #77

kyuhyongpark opened this issue Mar 26, 2022 · 3 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@kyuhyongpark
Copy link
Collaborator

While adding new parameter max_in_degree to the deletion_reduction in reduction.py,
I found that this function does not allow node names that have _ or - or start with numbers.

I think it is related to simplify_using_expression_and_negation in reduction.py.

@kyuhyongpark
Copy link
Collaborator Author

kyuhyongpark commented Mar 31, 2022

Right now there is no documentation or warning. User won't be notified that certain node names are not allowed unless the deletion reduction actually happens.

@kyuhyongpark kyuhyongpark changed the title deletion_reduction not allowing certain node names Making rule input more user-friendly Jun 16, 2022
@kyuhyongpark
Copy link
Collaborator Author

Another issue with the input rules is that it does not allow rules that do not have an empty space between not and (.
For example A* = not(B or C) cannot be imported and there is no warning or error message that tells the user why.

@jcrozum
Copy link
Owner

jcrozum commented Jun 23, 2022

The second issue, with the A*=not(B or C) should be easy enough to fix. Are you sure underscores cause an issue? I knew about the hyphen because sympy interprets it as a minus sign, but I was pretty certain we had tested with underscores. In any case, I agree that this kind of thing needs to be better documented.

@jcrozum jcrozum added bug Something isn't working documentation Improvements or additions to documentation labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants