Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fish #3

Closed
tbodt opened this issue Apr 13, 2017 · 3 comments
Closed

Support for fish #3

tbodt opened this issue Apr 13, 2017 · 3 comments

Comments

@tbodt
Copy link

tbodt commented Apr 13, 2017

Fish's history includes a little more information than just the command that was executed. ~/.local/share/fish/fish_history is a yaml file, here's a sample:

- cmd: v /usr/local/etc/rethinkdb.conf 
  when: 1492027898
  paths:
    - /usr/local/etc/rethinkdb.conf

As you can see it includes the command, a timestamp, and the filepaths references by the command.

@jcsalterego
Copy link
Owner

Whew! Unfortunately since historian is purely bash right now, we'd need some sort of... bash yaml parser (cc @mando).

This might be out of historian's depth :\

@mando
Copy link

mando commented Apr 14, 2017

I KNEW THIS DAY WOULD COME!

@jcsalterego
Copy link
Owner

@tbodt After some further consideration, I think proper YAML parsing won't be possible until historian is rewritten in something other than bash. I'm gonna go ahead and close the issue but I'll keep it in mind if I ever do a rewrite. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants